Fixed CWLConditionalStep persistence
#330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanderOtto
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 67.23% 67.25% +0.01%
==========================================
Files 82 82
Lines 10266 10269 +3
Branches 2430 2431 +1
==========================================
+ Hits 6902 6906 +4
+ Misses 2942 2941 -1
Partials 422 422 ☔ View full report in Codecov by Sentry. |
LanderOtto
force-pushed
the
fix/persistence
branch
from
530e2d9
to
407c8ed
Compare
LanderOtto
changed the title
GlassOfWhiskey
changed the title
GlassOfWhiskey
changed the title
CWLConditionalStep persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the CWLConditionalStep persistence loading its skip_ports attribute.
Fixed the unit test and added new unit tests on missing classes.