Fix valueFrom type checking behaviour
#323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the type checking behaviour with CWL `valueFrom` transformers. Before, the incorrect type was passed to the `TokenProcessor` class: the type resulting from the `valueFrom` expression evaluation. Instead, the correct type should be the type of the `source` value, i.e., before the expression evaluation. Since this type is difficult to infer, as the source could be still unknown at the evaluation time, now StreamFlow always passes `Any`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 67.09% 67.11% +0.02%
==========================================
Files 82 82
Lines 10253 10254 +1
Branches 2424 2424
==========================================
+ Hits 6879 6882 +3
+ Misses 2950 2949 -1
+ Partials 424 423 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the type checking behaviour with CWL
valueFromtransformers. Before, the incorrect type was passed to theTokenProcessorclass: the type resulting from thevalueFromexpression evaluation. Instead, the correct type should be the type of thesourcevalue, i.e., before the expression evaluation. Since this type is difficult to infer, as the source could be still unknown at the evaluation time, now StreamFlow always passesAny.