Fixed SSHClientConnection closing #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanderOtto
force-pushed
the
fix/transfer
branch
from
d14542d
to
fa2d573
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 66.01% 65.99% -0.03%
==========================================
Files 82 82
Lines 10235 10247 +12
Branches 2420 2422 +2
==========================================
+ Hits 6757 6762 +5
- Misses 3044 3050 +6
- Partials 434 435 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LanderOtto
force-pushed
the
fix/transfer
branch
from
82da5fc
to
86d25c6
Compare
LanderOtto
force-pushed
the
fix/transfer
branch
from
76760a4
to
c541acb
Compare
LanderOtto
force-pushed
the
fix/transfer
branch
from
c541acb
to
bb16cda
Compare
LanderOtto
force-pushed
the
fix/transfer
branch
4 times, most recently
from
b3b2c6d
to
f4cab90
Compare
LanderOtto
force-pushed
the
fix/transfer
branch
from
f4cab90
to
f6e7543
Compare
LanderOtto
added a commit
that referenced
this pull request
Dec 18, 2023
This commit fixes the anomalous `SSHClientConnection` closing caused by an improper handling of the `SSHContext` internal logic. Furthermore, now `ConnectionError` exceptions are catched and connections are properly handled in order to avoid problems with concurrent pending connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the
SSHClientConnectionclosing. Futhermore,ConnectionErrorare catched andSSHClientConnectionis closed to avoid problems with concurrent pending connections.