Adjusted local-to-remote copy with folders #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local-to-remote copy was failing when trying to copy a folder with multiple files, as only the first file was actually tansferred. This commit solves this issue by modifying the `aiotarstream` module to deal with `tell` and `seek` operations, allowing to position the stream pointer in the correct position. In detail, two new classes have been implemented: - `TellableStreamWrapper`, which keeps track of the actual stream pointer position; - `SeekableStreamReaderWrapper`, which allows forward seek operations in a stream reader. Note that these classes are internal to the `aiotarstram` module, so nothing changes in the publicly exposed API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local-to-remote copy was failing when trying to copy a folder with multiple files, as only the first file was actually tansferred. This commit solves this issue by modifying the
aiotarstreammodule to deal withtellandseekoperations, allowing to position the stream pointer in the correct position.In detail, two new classes have been implemented:
TellableStreamWrapper, which keeps track of the actual stream pointer position;SeekableStreamReaderWrapper, which allows forward seek operations in a stream reader.Note that these classes are internal to the
aiotarstrammodule, so nothing changes in the publicly exposed API.