Add warning messages for default connector params #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
queue-manager-warning-messages
branch
from
63b3f52
to
b7edce9
Compare
This commit adds two warning messages: - When a `QueueManagerConnector` is instantiated with the default value of 1 for the `maxConcurrentJobs` parameter; - When an `SSHConnector` or a `QueueManagerConnector` defines at least one service template, but none is selected to execute a step. This commit also substitutes the deprecated `logging.WARN` with the preferred `logging.WARNING` constant.
GlassOfWhiskey
force-pushed
the
queue-manager-warning-messages
branch
from
b7edce9
to
b5ff6ad
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
=======================================
Coverage 65.88% 65.89%
=======================================
Files 82 82
Lines 10149 10151 +2
Branches 2399 2398 -1
=======================================
+ Hits 6687 6689 +2
- Misses 3028 3029 +1
+ Partials 434 433 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two warning messages:
QueueManagerConnectoris instantiated with the default value of 1 for themaxConcurrentJobsparameter;SSHConnectoror aQueueManagerConnectordefines at least one service template, but none is selected to execute a step.This commit also substitutes the deprecated
logging.WARNwith the preferredlogging.WARNINGconstant.