Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable time option in HPC connectors #227

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

GlassOfWhiskey
Copy link
Member

This commit adds the possibility for users to specify a timeout value directly from the QueueManagerService options, i.e., in the deployment section of the streamflow.yml config file. If a value is inferred directly from a workflow step deifnition, the latter will prevail.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (953f84f) 64.28% compared to head (441f7f7) 64.23%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   64.28%   64.23%   -0.05%     
==========================================
  Files          82       82              
  Lines       10100    10106       +6     
  Branches     2386     2387       +1     
==========================================
- Hits         6493     6492       -1     
- Misses       3198     3204       +6     
- Partials      409      410       +1     
Files Changed Coverage Δ
streamflow/deployment/connector/queue_manager.py 19.40% <0.00%> (-0.32%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit adds the possibility for users to specify a `timeout` value
directly from the QueueManagerService options, i.e., in the `deployment`
section of the `streamflow.yml` config file. If a value is inferred
directly from a workflow step deifnition, the latter will prevail.
@GlassOfWhiskey GlassOfWhiskey merged commit 96c7eff into master Sep 7, 2023
27 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the allow-explicit-timeout-options branch September 7, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants