Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved StreamFlow provenance support #122

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

GlassOfWhiskey
Copy link
Member

This commit introduces two new options to the streamflow prov command:

  • The --add-file option allows user to add additional files and folders to the archive, potentially defining custom properties;

  • The --add-property option allows users to add/update properties in the provenance manifest, if present.

@GlassOfWhiskey GlassOfWhiskey force-pushed the enhance-prov branch 4 times, most recently from eb7b9be to 83daeae Compare April 25, 2023 03:21
This commit introduces two new options to the `streamflow prov` command:

- The `--add-file` option allows user to add additional files and
  folders to the archive, potentially defining custom properties;

- The `--add-property` option allows users to add/update properties in
  the provenance manifest, if present.

Plus, this commit corrects the way `docker` CWL configuration is
propagated to inner steps.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 16.07% and project coverage change: -0.73 ⚠️

Comparison is base (e10b9f7) 67.02% compared to head (2f4a2c8) 66.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   67.02%   66.30%   -0.73%     
==========================================
  Files          80       80              
  Lines        9460     9591     +131     
  Branches     2214     2252      +38     
==========================================
+ Hits         6341     6359      +18     
- Misses       2718     2832     +114     
+ Partials      401      400       -1     
Impacted Files Coverage Δ
streamflow/cwl/translator.py 87.57% <ø> (ø)
streamflow/main.py 36.87% <ø> (ø)
streamflow/provenance/run_crate.py 11.17% <9.21%> (-0.41%) ⬇️
streamflow/parser.py 92.50% <72.72%> (-7.50%) ⬇️
streamflow/config/config.py 38.15% <100.00%> (-2.64%) ⬇️
streamflow/core/provenance.py 66.66% <100.00%> (ø)
streamflow/deployment/connector/kubernetes.py 55.72% <100.00%> (+0.09%) ⬆️
streamflow/deployment/deployment_manager.py 73.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GlassOfWhiskey GlassOfWhiskey merged commit 7dad3fc into master Apr 25, 2023
@GlassOfWhiskey GlassOfWhiskey deleted the enhance-prov branch April 25, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants