-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds self.run_forever_flag to streams #501
base: master
Are you sure you want to change the base?
Conversation
ec75f00
to
0b4cae4
Compare
f3c281b
to
83a1f00
Compare
@@ -3,4 +3,4 @@ | |||
from .stream import Stream # noqa | |||
from .stream2 import StreamConn # noqa | |||
|
|||
__version__ = '1.4.0' | |||
__version__ = '1.4.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 0xfMissingNo! Version changes are necessary in your PR. They are made when we release and deploy a new version.
@@ -376,6 +379,7 @@ def __init__(self, | |||
self._ws = None | |||
self._running = False | |||
self._stop_stream_queue = queue.Queue() | |||
self._run_forever_flag = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this flag? What functionality does it add over while True
?
@@ -648,6 +654,22 @@ def run(self): | |||
print('keyboard interrupt, bye') | |||
pass | |||
|
|||
async def _close(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to contribute! To help us out, could you please elaborate a bit further on the goal of your PR?
wanted to handle async loops from a separate thread if need be; pushing my patch upstream: