Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support w8ben #520

Merged
merged 5 commits into from
Nov 13, 2024
Merged

feat: Support w8ben #520

merged 5 commits into from
Nov 13, 2024

Conversation

hiohiohio
Copy link
Contributor

Context:

  • UploadW8BenDocumentRequest is not used in the code path

Change:

  • add UploadW8BenDocumentRequest into accepting type for:
    • create_account
    • upload_documents_to_account

@hiohiohio hiohiohio marked this pull request as ready for review November 7, 2024 09:31
matebudai
matebudai reviewed Nov 13, 2024
View reviewed changes
alpaca/broker/requests.py
@@ -405,70 +469,6 @@ def root_validator(cls, values: dict) -> dict:
return values


class UploadW8BenDocumentRequest(NonEmptyRequest):
Copy link
Contributor

@matebudai matebudai Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the black formatter move this, or? As far as I can tell no change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the noice. I have moved the location!

matebudai
matebudai approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@matebudai matebudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hiohiohio hiohiohio merged commit 6ba117b into master Nov 13, 2024
12 checks passed
@hiohiohio hiohiohio deleted the feat-support-w8ben branch November 13, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matebudai matebudai matebudai approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiohiohio @matebudai