Added message property to APIError #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the error object returns both a code and message, both should be accessible to the end user. The end user can already access this by accessing the protected variable _error.
Swapped to match rest of file. This relates to alpacahq#431.
|
@hiohiohio could you please take a look at this PR? |
hiohiohio
approved these changes
Nov 6, 2024
|
@hiohiohio No worries. Thanks for getting to this! I'll start work on #136 now that this isn't blocking (this was sort of requisite). 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the APIError object returns both a code and message, both should be readily accessible to the end user. The end user can already access this by accessing the protected variable _error, but that isn't best practice.
This would address #431