Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix month rolling #81

Merged
merged 11 commits into from
Jul 14, 2017
Merged

Fix month rolling #81

merged 11 commits into from
Jul 14, 2017

Conversation

alonsodomin
Copy link
Owner

Adds failure handling when setting values into datetime objects, such that if invalid values to a field are assigned, the stepping process can recover from those by rolling up the next field in the chain.

Fixes #73 and #80

@codecov-io
Copy link

codecov-io commented Jul 14, 2017

Codecov Report

Merging #81 into master will increase coverage by 0.56%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage    91.4%   91.96%   +0.56%     
==========================================
  Files          52       62      +10     
  Lines         861      996     +135     
  Branches       42       45       +3     
==========================================
+ Hits          787      916     +129     
- Misses         74       80       +6
Impacted Files Coverage Δ
...ain/scala/cron4s/testkit/CronDateTimeTestKit.scala 100% <100%> (ø) ⬆️
.../src/main/scala/cron4s/datetime/DateTimeNode.scala 100% <100%> (ø) ⬆️
...hared/src/main/scala/cron4s/datetime/Stepper.scala 100% <100%> (ø) ⬆️
...ain/scala/cron4s/testkit/laws/IsDateTimeLaws.scala 100% <100%> (ø) ⬆️
...ala/cron4s/lib/javatime/JavaTemporalInstance.scala 85.71% <100%> (+0.52%) ⬆️
...src/main/scala/cron4s/lib/joda/JodaInstances.scala 87.3% <92.85%> (+2.68%) ⬆️
...main/scala/cron4s/testkit/gen/CronGenerators.scala 100% <0%> (ø) ⬆️
...main/scala/cron4s/testkit/discipline/package.scala 0% <0%> (ø) ⬆️
...e/shared/src/main/scala/cron4s/expr/CronExpr.scala 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f25726...3398f03. Read the comment docs.

@alonsodomin alonsodomin merged commit 773f10e into master Jul 14, 2017
@alonsodomin alonsodomin deleted the fix_month_rolling branch July 14, 2017 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants