Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifies JS & JVM implementation of JSR-310 #60

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Conversation

alonsodomin
Copy link
Owner

Removes all the JSR-310 backport stuff in org.threeten.bp by cross-compiling the java.time APIs in the JVM and JS, removing a lot of duplicate code.

@codecov-io
Copy link

codecov-io commented Apr 9, 2017

Codecov Report

Merging #60 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   92.46%   92.63%   +0.17%     
==========================================
  Files          61       59       -2     
  Lines         955      923      -32     
  Branches       45       41       -4     
==========================================
- Hits          883      855      -28     
+ Misses         72       68       -4
Impacted Files Coverage Δ
...d/src/main/scala/cron4s/lib/javatime/package.scala 85.71% <ø> (ø)
...ala/cron4s/lib/javatime/JavaTemporalInstance.scala 85.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0fba0a...784f441. Read the comment docs.

@alonsodomin alonsodomin merged commit 3922554 into master Apr 9, 2017
@alonsodomin alonsodomin deleted the unify_javatime branch April 9, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants