Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Shows and FieldExpr typeclasses. #36

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Conversation

alonsodomin
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 4, 2017

Codecov Report

Merging #36 into master will increase coverage by -0.15%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   88.77%   88.62%   -0.15%     
==========================================
  Files          58       58              
  Lines         748      756       +8     
  Branches       37       37              
==========================================
+ Hits          664      670       +6     
- Misses         84       86       +2
Impacted Files Coverage Δ
.../shared/src/main/scala/cron4s/expr/FieldExpr.scala 100% <ø> (ø)
core/shared/src/main/scala/cron4s/CronField.scala 100% <100%> (ø)
...n/scala/cron4s/testkit/laws/DateTimeCronLaws.scala 100% <100%> (ø)
.../cron4s/testkit/discipline/DateTimeCronTests.scala 100% <100%> (ø)
...e/shared/src/main/scala/cron4s/expr/wrappers.scala 50% <100%> (ø)
core/shared/src/main/scala/cron4s/expr/nodes.scala 67.39% <60%> (-3.35%)
...ore/shared/src/main/scala/cron4s/syntax/cron.scala 100% <ø> (+10%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405df6d...3eb6958. Read the comment docs.

@alonsodomin alonsodomin merged commit c733896 into master Feb 4, 2017
@alonsodomin alonsodomin deleted the decouple_shows branch February 4, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants