Replace Fastparse by Scala Parser Combinators #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal parser implementation based on Fastparse has becomed obsolete since the it moved to version 2.x, and support for Scala 2.13 and/or Scala Native will not happen for the 1.x version.
After several failed attempts on upgrading the parser to FastParse 2.x, I gave up due different reasons, from the new ackward syntax to change in behaviour of the actual parsers, which means that the whole parsing process needs to be re-written from scratch.
After playing with Scala Parser Combinators, I've seen that most of the code of the parser can be left unchanged while still preserving its original behaviour. Parser combinators already supports Scala Native and Scala 2.13-M5, so with this change we are one step closer to new Scala versions and in a more stable codebase.