Add Azure Key Vault module and integrate into Bicep deployment #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnuaimicoder
temporarily deployed
to
Development
GitHub Actions
Inactive
alnuaimicoder
added a commit
that referenced
this pull request
Dec 18, 2024
Merge pull request #1 from alnaimi-github/deploy-keyvault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the infrastructure setup and documentation. The most important changes include the addition of a new Key Vault module, modifications to the main infrastructure file to integrate the Key Vault, and an update to the subscription scope in the README file.
Infrastructure setup:
infrastructure/main.bicep: Added a new module for Key Vault deployment, including parameters forvaultNameandlocation.infrastructure/modules/secrets/keyvault.bicep: Created a new Key Vault module with parameters forlocationandvaultName, and defined the Key Vault resource with specific properties.Documentation update:
README.md: Updated the subscription scope in theaz ad sp create-for-rbaccommand.