Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat with 3.12, drop 3.6 #13

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Compat with 3.12, drop 3.6 #13

merged 2 commits into from
Apr 18, 2024

Conversation

almarklein
Copy link
Owner

@almarklein almarklein commented Apr 18, 2024

I saw some errors like this:

Exception ignored in: <function AsyncItemDB.__del__ at 0x103c65300>
Traceback (most recent call last):
  File "/Users/almar/dev/py/itemdb/itemdb.py", line 631, in __del__
    future = self._loop.create_future()

Not sure from what version this is happening (saw it on 3.11). This PR fixes that in drops 3.6 because the fix uses ascyncio.get_running_loop() and that's only available from 3.7.

@almarklein almarklein merged commit 38d8d3d into master Apr 18, 2024
10 checks passed
@almarklein almarklein deleted the py312 branch April 18, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant