Skip to content

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested review from a team as code owners September 1, 2025 13:00
@github-actions github-actions bot added the type: bugfix Bug fix label Sep 1, 2025
Copy link

sonarqubecloud bot commented Sep 1, 2025

@joyet-simon
Copy link
Contributor Author

@alma/squad-devx Can you make a review please?

Copy link
Contributor

@remi-zuffinetti remi-zuffinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to add one Dockerfile per dev tool we want to use?

I can approve now if it unlocks you, but I think it would be better to have a single kind of "devbox" like we have in main to run all our linters, if they require to be run with Docker.

@webaaz webaaz merged commit d914843 into develop Sep 5, 2025
12 checks passed
@webaaz webaaz deleted the fix/pre-commit branch September 5, 2025 13:29
@webaaz webaaz mentioned this pull request Sep 5, 2025
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma added skip-changelog Exclude this change from the next release changelog and removed type: bugfix Bug fix labels Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Exclude this change from the next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants