Add dynamic lib + single threaded option + CI job #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sno2
reviewed
May 11, 2025
.github/workflows/zig.yml
Outdated
| branches: master | ||
| pull_request: | ||
| schedule: | ||
| - cron: "0 18 * * *" |
There was a problem hiding this comment.
Why does this have a cron job? The zlib version will never change unless if the build.zig.zon is manually updated.
sno2
reviewed
May 11, 2025
.github/workflows/zig.yml
Outdated
| on: | ||
| create: | ||
| push: | ||
| branches: master |
There was a problem hiding this comment.
Suggested change
| branches: master | |
| branches: main |
I think this needs to point to main.
sno2
reviewed
May 11, 2025
.github/workflows/zig.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: mlugg/setup-zig@v1 |
There was a problem hiding this comment.
Suggested change
| - uses: mlugg/setup-zig@v1 | |
| - uses: mlugg/setup-zig@v2 |
I believe the new version just got released. mlugg/setup-zig@aa9ad5c
jdmichaud
force-pushed
the
improvement
branch
2 times, most recently
from
30df5bd to
3f76903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.