Barchart/marker #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxeradus
suggested changes
Oct 9, 2025
LarsStegman
requested changes
Oct 27, 2025
There was a problem hiding this comment.
Great job! You really managed to get something nice, even though the surrounding code is a bit of a mess. I haven't managed to get Grafana to start yet on my machine, but the code looks good already! I will attempt again to get it to run. Most of my suggestions are cosmetic or small things.
| return { barData, markerData }; | ||
| } | ||
|
|
||
| export function deepCopy<T>(obj: T, seen = new Map<any, any>()): T { |
There was a problem hiding this comment.
This must already exist as a library function somewhere right? I would search for that. I can't imagine this is the first time it's needed.
| max={2} | ||
| step={0.01} | ||
| value={marker.opts.size ?? 1} | ||
| onChange={(v) => handleOptsSettingChange(marker.id, 'size', typeof v === 'number' ? v : v[0])} |
There was a problem hiding this comment.
v will always be a number according to my type checker, so you don't need to do the typeof check
Co-authored-by: Lars Stegman <LarsStegman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This feature allows the user to add markers to a barchart based on an input field.
Why do we need this feature?
This feature allows the user to visualize a threshold
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
**Special notes for your reviewer:**x
Please check that: