chore: update unsafe function and improve documentation and safety notes - #552
Merged
Conversation
3 tasks
CodSpeed Performance ReportMerging #552 will degrade performance by 25.92%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
cc @DaniPopes in case you want to look into why benches have changed |
DaniPopes
approved these changes
Dec 25, 2025
Member
|
Likely due to new Rust stable version, I also saw this on a CI change not that long ago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #550
Supersedes #551
Addresses rustsec/advisory-db#2538
Solution
Review safety of unstable crate API functions. Ensure that functions with COUs that may result in UB are marked as unsafe, and have clear COU documentation
PR Checklist