network: Add status method to ReceiptResponse trait

[moricho]

Motivation

from: #845

It would be helpful to know the tx status from the receipt gotten by get_receipt method in PendingTransactionBuilder or by get_transaction_receipt in Provider.

Solution

Define status method in ReceiptResponse trait and implement it in TransactionReceipt for each network

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[prestwich]

directionally approve. can you copy the doc warnings from #848 ?

    /// ## Note
    ///
    /// Caution must be taken when using this method for deep-historical
    /// receipts, as it may not accurately reflect the status of the
    /// transaction. The transaction status is not knowable from the receipt
    /// for transactions before [EIP-658].
    ///
    /// This can be handled using [`TxReceipt::status_or_post_state`].
    ///
    /// [EIP-658]: https://eips.ethereum.org/EIPS/eip-658

[prestwich]

cc @mattsse should type ReceiptResponse: ReceiptResponse also be constrained to + AsRef<Self::ReceiptEnvelope> to ensure that network implementers ALWAYS embed the envelope in the response?

[mattsse]

ah, right this way we could enforce embedding the receipt type in rpc, so ReceiptResponse is Receipt + BlockContext

this makes sense, then we could also add Into<Self::ReceiptEnvelope>

[prestwich]

this is more work than belongs in this PR. captured in #854

[moricho]

@prestwich Added the doc warnings ✅

[mattsse]

duplicating the docs is not necessary imo

[prestwich]

i'd like the docs to be on every place the user may encounter this (potentially confusing) behavior

[prestwich]

trait impls never need docstrings tho :)

[DaniPopes]

yes, they are inherited from the trait definition, pls remove

[moricho]

I got it, removed the docs from the trait impls: b42dce5