Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocked] Update TransactionRequest's to field to TxKind #553

Merged
merged 20 commits into from
Apr 23, 2024
Merged

[Blocked] Update TransactionRequest's to field to TxKind #553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4495f5c
feat: change the `to` field type to TxKind, update From<TxEip4844> ac…
EmperorOrokuSaki Apr 16, 2024
f2118d1
Merge pull request #1 from EmperorOrokuSaki/main
EmperorOrokuSaki Apr 17, 2024
ecd45f4
refactor: update builder functions to include `to` checks.
EmperorOrokuSaki Apr 17, 2024
6de9d4f
feat: add as_create(), with_call(), and deploy_code()
EmperorOrokuSaki Apr 17, 2024
b1b7e08
refactor: remove error lines
EmperorOrokuSaki Apr 17, 2024
fc8b67f
feat: with_call impl.
EmperorOrokuSaki Apr 17, 2024
48b8d7a
feat: add the methods to the builder trait, update code that was broken.
EmperorOrokuSaki Apr 17, 2024
3e4bda9
test: update tests.
EmperorOrokuSaki Apr 17, 2024
4c531bf
nits: reordering and default impls
prestwich Apr 18, 2024
f8861f7
fix: some test compilation
prestwich Apr 18, 2024
17d7e3f
nit: fmt
prestwich Apr 18, 2024
554e7cc
lint: clippy
prestwich Apr 18, 2024
b0b4ff0
test: fix tests
prestwich Apr 18, 2024
a804338
refactor: kind vs to
prestwich Apr 18, 2024
b6dfa0a
feat: new_raw_deploy and generic input
prestwich Apr 19, 2024
8a96578
doc: add note re sol usage
prestwich Apr 20, 2024
296de0a
fix: type inference in test
prestwich Apr 20, 2024
3c90f5f
Merge branch 'main' into feat/txrequest_creation
DaniPopes Apr 23, 2024
6a2a244
chore: update core
DaniPopes Apr 23, 2024
5c24e6c
docs
DaniPopes Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: some test compilation
  • Loading branch information
@prestwich
prestwich committed Apr 18, 2024
commit f8861f720a1e3c505c1f52df2cb9b159bb84867b
6 changes: 3 additions & 3 deletions crates/provider/src/fillers/gas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ mod tests {
let tx = TransactionRequest {
from: Some(anvil.addresses()[0]),
value: Some(U256::from(100)),
to: address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into(),
to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()),
Copy link
Member

@gakonst gakonst Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be using TransactionBuilder instead of defining the transaction fully?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but its just tests so i didn't want to clutter the diff

chain_id: Some(31337),
..Default::default()
};
Expand All @@ -288,7 +288,7 @@ mod tests {
let tx = TransactionRequest {
from: Some(anvil.addresses()[0]),
value: Some(U256::from(100)),
to: address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into(),
to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()),
gas_price: Some(gas_price),
..Default::default()
};
Expand All @@ -311,7 +311,7 @@ mod tests {
let tx = TransactionRequest {
from: Some(address!("f39Fd6e51aad88F6F4ce6aB8827279cffFb92266")),
value: Some(U256::from(100)),
to: address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into(),
to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()),
// access list forces legacy gassing
access_list: Some(vec![Default::default()].into()),
..Default::default()
Expand Down
4 changes: 2 additions & 2 deletions crates/provider/src/fillers/nonce.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ mod tests {

let tx = TransactionRequest {
value: Some(U256::from(100)),
to: address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into(),
to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()),
gas_price: Some(20e9 as u128),
gas: Some(21000),
..Default::default()
Expand All @@ -146,7 +146,7 @@ mod tests {
let tx = TransactionRequest {
from: Some(from),
value: Some(U256::from(100)),
to: address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into(),
to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()),
gas_price: Some(20e9 as u128),
gas: Some(21000),
..Default::default()
Expand Down
2 changes: 1 addition & 1 deletion crates/provider/src/fillers/signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ mod tests {
let tx = TransactionRequest {
nonce: Some(0),
value: Some(U256::from(100)),
to: address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into(),
to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()),
gas_price: Some(20e9 as u128),
gas: Some(21000),
..Default::default()
Expand Down
Loading