fix(serde): handle overflow in quantity deserialization for Arbitrum gas prices

[avorylli]

Fixes deserialization failures when processing Arbitrum Classic blocks with extremely high gas prices that overflow u128.

Problem:

• Arbitrum Classic used unbounded gas price bids
• Values like 0x30783134626639633464372e3333333333333333333333333333333333333333 cause u128 overflow
• Deserialization panics instead of gracefully handling overflow

Solution:

• Modified ConvertRuint::from_ruint() to return 0 on overflow instead of panicking
• Added overflow_default() method to trait for configurable overflow handling
• Implemented for all primitive types (u8, u16, u32, u64, u128, bool)

Closes #2842

[graphite-app]

The current approach of returning 0 for all numeric types during overflow may not be semantically appropriate for all use cases. For gas prices specifically, defaulting to 0 could potentially allow transactions to be processed without fees, which might lead to economic issues or unexpected behavior.

Consider making the overflow handling more context-aware:

1. Either return a Result type instead of using unwrap_or_else to propagate the error to the caller
2. Or make the default value configurable based on the specific field being deserialized (perhaps with a trait parameter)
3. For gas prices specifically, a more appropriate default might be u128::MAX or another value that aligns with the expected behavior

This would ensure that overflow handling is semantically appropriate for each specific use case rather than using a one-size-fits-all approach.

Suggested change

	ruint.try_into().unwrap_or_else(|_| Self::overflow_default())
	ruint.try_into().map_err(|_| serde::de::Error::custom("numeric overflow"))?

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

[mattsse]

we cant really approach this like this, because we'd need to specialize the actual serde impl manually and cant change the regular quantity fn

[jaggad]

we cant really approach this like this, because we'd need to specialize the actual serde impl manually and cant change the regular quantity fn

if we're aiming for "I think we could make this u128::Max and maybe store it in an otherfield as u256 if it's for AnyBlock", how would you go about approaching it?

[mattsse]

the only way to do this really is manual serde impl on the block type

[avorylli]

@mattsse
So I created a gas_price module in quantity.rs that handles overflow specifically for gas prices

And updated the transaction types to use it and reverted the ConvertRuint changes.

I hope this should fix the Arbitrum issue without breaking anything else.

[jaggad]

I think this looks pretty good.

@avorylli @mattsse What do we think is needed to get this over the line, it's a pretty high value addition for our use case right now. If we think it can merge soon I'll wait, otherwise I might try and build from this fork?

[jaggad]

@mattsse Is there anything holding up this PR from being merged from your perspective?

[desfero]

@mattsse we would also greatly benefit if this PR get's merged and new released pushed 🙏

[DaniPopes]

Closed in favor of #3010. This requires too many changes to fix the AI slop and has unrelated changes.