Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc-types-eth): receipt deser #1506

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Oct 17, 2024

Motivation

Closes #1493

Solution

state_root in TransactionReceipt would conflict with Eip658::PostState(root) in Receipt as both have serde aliases set as root. Remove state_root.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya self-assigned this Oct 17, 2024
@yash-atreya yash-atreya changed the title tests fix(rpc-types-eth): receipt deser Oct 17, 2024
crates/rpc-types-eth/src/transaction/receipt.rs Outdated Show resolved Hide resolved
@yash-atreya
Copy link
Member Author

CI will get fixed when we bump alloy in anvil with this change.
Currently anvil sets the state_root in the TransactionReceipt

@yash-atreya yash-atreya marked this pull request as ready for review October 18, 2024 05:45
@yash-atreya yash-atreya merged commit 0cb3cf6 into main Oct 18, 2024
26 checks passed
@yash-atreya yash-atreya deleted the yash/fix-deser-receipt-root branch October 18, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Can't deserialize old transaction receipts
2 participants