Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to configure Ws config #1505

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

1makarov
Copy link
Contributor

@1makarov 1makarov commented Oct 16, 2024

closes #1504

crates/transport-ws/src/native.rs Outdated Show resolved Hide resolved
@1makarov 1makarov requested a review from mattsse October 17, 2024 17:06
crates/transport-ws/src/native.rs Outdated Show resolved Hide resolved
@mattsse
Copy link
Member

mattsse commented Oct 17, 2024

needs fmt and clippy, can't apply myself because opened from main branch

@DaniPopes
Copy link
Member

Any downsides to this?

@mattsse
Copy link
Member

mattsse commented Oct 17, 2024

only that this breaks exhaustive WsConnect {} usage, by default this still uses the default tungs. config but now this can be configured on WsConnect manually

@mattsse mattsse changed the title accepting websocket messages of any size feat: make it possible to configure Ws config Oct 17, 2024
@1makarov 1makarov requested a review from mattsse October 17, 2024 20:08
@1makarov
Copy link
Contributor Author

Any downsides to this?

Those who use the WsConnect::with_auth(url, header) construct will have to update to WsConnect::new(url).with_auth(header)

@mattsse mattsse merged commit 7be4628 into alloy-rs:main Oct 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] websocket cannot return a long response
3 participants