Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alloy-dyn-contract #149

Merged
merged 18 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: do not set eip-1559 gas
  • Loading branch information
onbjerg committed Jan 25, 2024
commit fb4b62552ff3a5d6ad078cfe6f3e7899d3310655
3 changes: 3 additions & 0 deletions crates/alloy-dyn-contract/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# alloy-dyn-contract

Helpers for interacting with contracts that do not have a known ABI at compile time.

This is primarily useful for e.g. CLIs that load an ABI at run-time,
and ABI encode/decode data based on user input.
4 changes: 1 addition & 3 deletions crates/alloy-dyn-contract/src/call.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,8 @@ impl<P> CallBuilder<P> {
/// If the internal transaction is an EIP-1559 one, then it sets both
/// `max_fee_per_gas` and `max_priority_fee_per_gas` to the same value
pub const fn gas_price(mut self, gas_price: U256) -> Self {
// todo: differentiate between eip-1559 and legacy once we have typedtx
// todo: Add EIP-1559 support
self.request.gas_price = Some(gas_price);
self.request.max_fee_per_gas = Some(gas_price);
self.request.max_priority_fee_per_gas = Some(gas_price);
self
}

Expand Down