eips: update fn encoded_2718 #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkysg
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
reviewed
Oct 14, 2024
| @@ -208,7 +208,7 @@ pub trait Encodable2718: Sized + Send + Sync + 'static { | |||
| /// This is a convenience method for encoding into a vec, and returning the | |||
| /// vec. | |||
| fn encoded_2718(&self) -> Vec<u8> { | |||
| let mut out = vec![]; | |||
| let mut out = Vec::with_capacity(self.encode_2718_len()); | |||
There was a problem hiding this comment.
I believe this is problematic because this could end up doing encoding twice @klkvr ?
but idk
There was a problem hiding this comment.
we already do this in alloy_rlp::encode: https://github.com/alloy-rs/rlp/blob/44606e88cb7ca9397a5b5e57a3299d4ae0305e01/crates/rlp/src/encode.rs#L292
and we don't even provide default encode_2718_len here so I think it's OK to expect implementations to provide a smarter impl
should be fine imo
mattsse
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use Vec::with_capacity avoid realloc
Motivation
Solution
PR Checklist