feat: impl From<Eip2718Error> for alloy_rlp::Error #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
approved these changes
Sep 25, 2024
Comment on lines
57
to
58
| #[cfg(feature = "std")] | ||
| impl std::error::Error for Eip2718Error {} |
There was a problem hiding this comment.
unrelated: this lacks fn source which should return the wrapped rlperr
mind fixing this in a separate pr quickly?
This was referenced Sep 25, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Eip2718Erroris just a more specific decoding error and it is useful to have an easy way to convert it to alloy-rlp errorSolution
PR Checklist