fix: make Parity TraceResults output optional #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That will resolve the issue when the RPC server returns "output": null, as Nethermind does.
m1stoyanov
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jul 25, 2024
DaniPopes
changed the title
mattsse
reviewed
Jul 26, 2024
| }, | ||
| "trace": [], | ||
| "vmTrace": null, | ||
| "transactionHash": "0xe56a5e7455c45b1842b35dbcab9d024b21870ee59820525091e183b573b4f9eb" |
There was a problem hiding this comment.
is this a real transaction?
wasn't able to find it
There was a problem hiding this comment.
Comment on lines
+826
to
+828
| fn test_nethermind_trace_result_null_output_value() { | ||
| let reference_data = r#"{ | ||
| "output": null, |
There was a problem hiding this comment.
is there a nethermind issue for this, I want to understand when this can be null to rule out something we may have missed
There was a problem hiding this comment.
To be honest, I didn't dig very deeply, but it seems that vm_trace can also be null.
mattsse
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
looking at the og docs
https://openethereum.github.io/JSONRPC-trace-module#trace_transaction
it looks like output should always be there
so treating null as empty makes sense
DaniPopes
approved these changes
Jul 26, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* Update parity.rs Bytes to Option<Bytes> That will resolve the issue when the RPC server returns "output": null, as Nethermind does. * Use null_as_default for handling null output and added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That will resolve the issue when the RPC server returns "output": null, as Nethermind does.
Motivation
That will resolve the issue when the RPC server returns "output": null, as Nethermind does.
Solution
PR Checklist