[Bug] ChainStreamPoller doesn't handle reorgs

[popzxc]

Component

provider, pubsub

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

ChainStreamPoller doesn't seem to account for reorgs at all, e.g. here it always expects the chain to be continuous.
And to fix that we probably need to compare block tip against next_yield here, and if block_number < next_yield, we should do some kind of search for the last non-diverging block (so probably we need to poll not only for block number, but rather for block header to use root hashes for comparison).

See this comment for more context.

[popzxc]

I think I know how to fix this issue and will try to do it this week.

[gakonst]

Can we close this?

[popzxc]

Not really; the linked PR only implemented the Heartbeat part of reorg handling, while this ticket is about ChainStreamPoller.
But with said PR merged, I'm unblocked to work on it, and hope to do it this week.

[yash-atreya]

I believe this was resolved by #1321

Closing optimistically