fix: cfg attr for wasm

alloy-rs · Mar 11, 2024 · b3db0fe · b3db0fe
1 parent 16b328e
commit b3db0fe
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/crates/network/Cargo.toml b/crates/network/Cargo.toml
@@ -22,5 +22,8 @@ async-trait.workspace = true
 serde = { workspace = true, features = ["derive"] }
 thiserror.workspace = true
 
+[dev-dependencies]
+tokio.workspace = true
+
 [features]
 k256 = ["alloy-primitives/k256", "alloy-consensus/k256"]
diff --git a/crates/network/src/ethereum/mod.rs b/crates/network/src/ethereum/mod.rs
@@ -30,7 +30,8 @@ impl Network for Ethereum {
     type HeaderResponse = alloy_rpc_types::Header;
 }
 
-#[async_trait]
+#[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
+#[cfg_attr(not(target_arch = "wasm32"), async_trait)]
 impl TransactionBuilder<Ethereum> for alloy_rpc_types::TransactionRequest {
     fn chain_id(&self) -> Option<alloy_primitives::ChainId> {
         self.chain_id

diff --git a/crates/network/src/transaction/builder.rs b/crates/network/src/transaction/builder.rs
@@ -43,7 +43,8 @@ pub type BuilderResult<T, E = TransactionBuilderError> = std::result::Result<T,
 ///
 /// Transaction builders should be able to construct all available transaction types on a given
 /// network.
-#[async_trait]
+#[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
+#[cfg_attr(not(target_arch = "wasm32"), async_trait)]
 pub trait TransactionBuilder<N: Network>: Default + Sized + Send + Sync + 'static {
     /// Get the chain ID for the transaction.
     fn chain_id(&self) -> Option<ChainId>;

diff --git a/crates/network/src/transaction/signer.rs b/crates/network/src/transaction/signer.rs
@@ -4,15 +4,17 @@ use async_trait::async_trait;
 
 // todo: move
 /// A signer capable of signing any transaction for the given network.
-#[async_trait]
+#[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
+#[cfg_attr(not(target_arch = "wasm32"), async_trait)]
 pub trait NetworkSigner<N: Network>: Sync {
     /// Asynchronously sign an unsigned transaction.
     async fn sign(&self, tx: N::UnsignedTx) -> alloy_signer::Result<N::TxEnvelope>;
 }
 
 // todo: move
 /// An async signer capable of signing any [SignableTransaction] for the given [Signature] type.
-#[async_trait]
+#[cfg_attr(target_arch = "wasm32", async_trait(?Send))]
+#[cfg_attr(not(target_arch = "wasm32"), async_trait)]
 pub trait TxSigner<Signature> {
     /// Asynchronously sign an unsigned transaction.
     async fn sign_transaction(