Add ZED2i support to simulation #231
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
* Fix realsense in simulation. Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com> * Add tests for realsense. Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com> * Move realsense launch to rcdt_sensors. Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com> --------- Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
…s available on Python 3.12. Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
…files Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
Signed-off-by: Jelmer de Wolde <jelmer.de.wolde@alliander.com>
… and streamline container operations Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
…pace workflow Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
…eraction Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
…223-add-zed2i-to-simulation
…build and test steps Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
…223-add-zed2i-to-simulation
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
…223-add-zed2i-to-simulation
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
…3-add-zed2i-to-simulation Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
…fy branch in git clone Signed-off-by: Max Waterhout <max.waterhout@hotmail.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the zed2i to the devcontainer for simulation. The bridged topics have the same name and is the image from the left optical frame. The description of the camera is copied from the ros-wrapper.
There is an sim:=true in the launch file of the ros-wrapper but this is only for nvidia isaac and not for gazebo so we use a bridge
Fixes: #223
Testing
I have tested that the names correspond with simulation and real camera.
Documentation
Additional Notes
I do not know if i have correctly added the Zed2i camera in the panther xacro, in the velodyne PR we just removed it and made it is own robot.