Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Commit

Permalink
Agr 417 - External links not working (#332)
Browse files Browse the repository at this point in the history
* Replaced react component <LINK> with <a> for external links

* Replaced react component <LINK> with <a> for external links
  • Loading branch information
LucyHut authored and Bryon Czoch committed May 30, 2017
1 parent 578823a commit 1cb78bc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
13 changes: 6 additions & 7 deletions webapp/src/containers/layout/socialMedia.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React, {Component} from 'react';
import { Link } from 'react-router';

class SocialMedia extends Component {
render() {
Expand All @@ -13,15 +12,15 @@ class SocialMedia extends Component {

return (
<p>
<Link to={facebook_link}>
<a href={facebook_link}>
<img src={facebook_logo} />
</Link>
<Link to={twitter_link}>
</a>
<a href={twitter_link}>
<img src={twitter_logo} />
</Link>
<Link to={github_link}>
</a>
<a href={github_link}>
<img src={github_logo} />
</Link>
</a>
</p>
);
}
Expand Down
3 changes: 1 addition & 2 deletions webapp/src/containers/layout/topBar.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import React, {Component} from 'react';
import { Link } from 'react-router';

import { SMALL_COL_CLASS, LARGE_COL_CLASS } from '../../constants';
import SocialMedia from './socialMedia';
Expand All @@ -16,7 +15,7 @@ class TopBar extends Component {
<div className={style.content}>
<div className={`${SMALL_COL_CLASS} ${style.miniBidgets}`}>
<span className={`${style.miniContact} ${style.email}`}>
<Link to={email_link}><i className='fa fa-envelope' /> {email_logo}</Link>
<a href={email_link}><i className='fa fa-envelope' /> {email_logo}</a>
</span>
</div>
<div className={`${LARGE_COL_CLASS} ${style.rightWidgets} ${style.miniBidgets}`}>
Expand Down

0 comments on commit 1cb78bc

Please sign in to comment.