Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README and type documentation #15

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Add README and type documentation #15

merged 6 commits into from
Jan 3, 2024

Conversation

dlh01
Copy link
Member

@dlh01 dlh01 commented Dec 27, 2023

Summary

As titled.

Notes for reviewers

None.

README.md Outdated
Comment on lines 25 to 26
- [Serialized Blocks](docs/blocks.md)
- [Single Block](docs/blocks.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see docs/single-block.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Thanks.

Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


All `Single_Block` implementations also implement `Serialized_Blocks`.

- [Inner_Blocks_Prepended](https://github.com/alleyinteractive/wp-type-extensions/blob/main/src/alley/wp/blocks/class-inner-blocks-prepended.php):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this item separate from the rest of the list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-paste flub. It's included in single-block.md.

@dlh01 dlh01 merged commit 89bb8c9 into main Jan 3, 2024
6 checks passed
@dlh01 dlh01 deleted the feature/docs branch January 3, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants