Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEDE-2616: Header and Footer Enhancements #134

Merged
merged 9 commits into from
Jun 3, 2024

Conversation

efuller
Copy link
Contributor

@efuller efuller commented May 31, 2024

Summary

  • Adds in a filter to enable/disable ads support
  • Fixes a bug that was causing header images to not display
  • Adds in a custom 'Manage Subscription Preferences' link -- in the footer block

Notes for reviewers

Changelog entries

Added

  • a filter to enable/disable ads

Changed

  • footer markup to allow for a custom subscription management link

Removed

Fixed

  • header images not displaying
  • footer settings not displaying

Ticket(s)

https://alleyinteractive.atlassian.net/browse/LEDE-2616

Copy link
Member

@kevinfodness kevinfodness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍣

@efuller efuller merged commit 4322ba4 into develop Jun 3, 2024
7 checks passed
@efuller efuller deleted the feature/header-footer-enhancements branch June 3, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants