Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: SendGrid Provider Updates #118

Merged
merged 9 commits into from
May 9, 2024

Conversation

efuller
Copy link
Contributor

@efuller efuller commented May 8, 2024

Summary

  • Update the SendGrid provider so it more consistently sends emails
  • Adjust some of the markup so the Email Settings block works as expected
  • Add a wrapper component for the <Spinner /> component. See GH issue here

Copy link
Collaborator

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. I wanted to give you a heads up about #108
which will be a Lede requirement, I'm pretty sure.

- Adds a `NewsletterSpinner` wrapper component for the `<Spinner />` component from `@wordpress/components`
- [see link to GitHub issue](https://github.com/WordPress/gutenberg/issues/61322)
- Change `nb_newsletter_template` post meta from type `string` to type `number`
- Change SendGrid Provider to send `suppression_group_id` and remove sending `custom_unsubscribe_url`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: #108

@efuller efuller merged commit e4543ed into develop May 9, 2024
7 checks passed
@efuller efuller deleted the feature/sendgrid-provider-updates branch May 9, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants