Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for 1.0 release and PHPUnit 10 #215

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Preparing for 1.0 release and PHPUnit 10 #215

merged 5 commits into from
Apr 5, 2024

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Nov 30, 2023

  • Migrates tests to PSR-4.
  • Upgrades mantle-framework to 1.0.
  • Drops PHP 8.0 support.

Summary by CodeRabbit

  • Refactor

    • Renamed classes and traits for improved consistency and clarity in test files.
  • Tests

    • Updated test execution times to be represented as a JSON object.
    • Renamed test classes for standardization.
  • Chores

    • Enhanced GitHub workflow triggers to support version-like branch names (ending in .x and *.*.x).
    • Adjusted PHP versions in test workflows to include 8.1 and 8.2, removing version 8.0.

Copy link

coderabbitai bot commented Nov 30, 2023

Warning

Rate Limit Exceeded

@srtfisher has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 8 minutes and 4 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between ead09a7 and eff5e62.

Walkthrough

The changes across various files indicate a refactoring and update in the testing infrastructure of a PHP project. Class and trait names have been standardized for clarity, and the GitHub Actions workflows have been updated to trigger on branches with version-like names and to test against newer PHP versions, dropping support for an older version.

Changes

File(s) Change Summary
.phpunit.cache/test-results Added a JSON object representing test execution times.
tests/CreateApplication.php, tests/TestCase.php, tests/feature/ExampleTest.php Renamed classes and traits for consistency (e.g., Create_Application to CreateApplication, Test_Case to TestCase).
.github/workflows/... Updated workflows to trigger on version-like branch names (*.x, *.*.x) and modified PHP versions in the test matrix to 8.1 and 8.2, removing 8.0.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ee36991 and 1405da1.
Files ignored due to filter (2)
  • composer.json
  • phpunit.xml
Files selected for processing (4)
  • .phpunit.cache/test-results (1 hunks)
  • tests/CreateApplication.php (1 hunks)
  • tests/TestCase.php (1 hunks)
  • tests/feature/ExampleTest.php (1 hunks)
Files skipped from review due to trivial changes (3)
  • tests/CreateApplication.php
  • tests/TestCase.php
  • tests/feature/ExampleTest.php
Additional comments: 1
.phpunit.cache/test-results (1)
  • 1-1: The update to the .phpunit.cache/test-results file appears to be correctly formatted and consistent with the PHPUnit 10 requirements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1405da1 and ead09a7.
Files selected for processing (3)
  • .github/workflows/coding-standards.yml (1 hunks)
  • .github/workflows/node-tests.yml (1 hunks)
  • .github/workflows/tests.yml (2 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/coding-standards.yml
  • .github/workflows/node-tests.yml
Additional comments: 2
.github/workflows/tests.yml (2)
  • 4-10: The workflow has been correctly updated to trigger on push events for branches matching '.x' and '.*.x'. Ensure that this pattern aligns with the branching strategy used in the repository.

  • 14-20: The PHP versions in the test matrix have been updated to 8.1 and 8.2, and version 8.0 has been removed. This should be cross-checked with the project's requirements to ensure compatibility with the supported PHP versions.

@srtfisher srtfisher merged commit afee539 into main Apr 5, 2024
10 checks passed
@srtfisher srtfisher deleted the release/1.0 branch April 5, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant