-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for 1.0 release and PHPUnit 10 #215
Conversation
Warning Rate Limit Exceeded@srtfisher has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 8 minutes and 4 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe changes across various files indicate a refactoring and update in the testing infrastructure of a PHP project. Class and trait names have been standardized for clarity, and the GitHub Actions workflows have been updated to trigger on branches with version-like names and to test against newer PHP versions, dropping support for an older version. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- composer.json
- phpunit.xml
Files selected for processing (4)
- .phpunit.cache/test-results (1 hunks)
- tests/CreateApplication.php (1 hunks)
- tests/TestCase.php (1 hunks)
- tests/feature/ExampleTest.php (1 hunks)
Files skipped from review due to trivial changes (3)
- tests/CreateApplication.php
- tests/TestCase.php
- tests/feature/ExampleTest.php
Additional comments: 1
.phpunit.cache/test-results (1)
- 1-1: The update to the
.phpunit.cache/test-results
file appears to be correctly formatted and consistent with the PHPUnit 10 requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .github/workflows/coding-standards.yml (1 hunks)
- .github/workflows/node-tests.yml (1 hunks)
- .github/workflows/tests.yml (2 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/coding-standards.yml
- .github/workflows/node-tests.yml
Additional comments: 2
.github/workflows/tests.yml (2)
4-10: The workflow has been correctly updated to trigger on push events for branches matching '.x' and '.*.x'. Ensure that this pattern aligns with the branching strategy used in the repository.
14-20: The PHP versions in the test matrix have been updated to 8.1 and 8.2, and version 8.0 has been removed. This should be cross-checked with the project's requirements to ensure compatibility with the supported PHP versions.
mantle-framework
to 1.0.Summary by CodeRabbit
Refactor
Tests
Chores
.x
and*.*.x
).