Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Faker deprecation warnings about accessing methods as parameters #270

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix Faker deprecation warnings about accessing methods as parameters #270

merged 1 commit into from
May 19, 2022

Conversation

anubisthejackle
Copy link
Contributor

@anubisthejackle anubisthejackle commented May 19, 2022 •
edited
Loading

During some testing it became apparent that in certain configurations, Faker was throwing a deprecation warning which was causing some tests to fail.

This PR updates Mantle's use of Faker to avoid those deprecation warnings.

srtfisher
srtfisher approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@srtfisher srtfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@anubisthejackle anubisthejackle merged commit e5aff55 into main May 19, 2022
@anubisthejackle anubisthejackle deleted the fix-faker-deprecation-warning branch May 19, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srtfisher srtfisher srtfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anubisthejackle @srtfisher