Add VIP config file #98
Conversation
|
|
||
| echo "Done!\n\n"; | ||
| } elseif ( 'pantheon' === $hosting_provider ) { | ||
| write( 'Deleting VIP-specific GitHub Action workflows...' ); | ||
|
|
||
| delete_files( | ||
| [ | ||
| 'vip-config', |
There was a problem hiding this comment.
when/where is this being created that it is necessary to delete this at this point?
There was a problem hiding this comment.
@jakewrfoster I guess as part of the repo we have vip-config/vip-config.php that needs to be removed?
| /** | ||
| * Set a high default limit to avoid too many revisions from polluting the database. | ||
| * | ||
| * @see https://docs.wpvip.com/technical-references/vip-platform/post-revisions/ | ||
| * | ||
| * Posts with high revisions can result in fatal errors or have performance issues. | ||
| * | ||
| * Feel free to adjust this depending on your use cases. | ||
| */ | ||
| if ( ! defined( 'WP_POST_REVISIONS' ) ) { | ||
| define( 'WP_POST_REVISIONS', 100 ); | ||
| } |
There was a problem hiding this comment.
I wonder if this should be moved to Alleyvate. maybe @kevinfodness can weigh in on this? I assume we would want this same approach to employed on Pantheon sites as well as VIP sites.
There was a problem hiding this comment.
It comes from https://github.com/Automattic/vip-go-skeleton/blob/production/vip-config/vip-config.php
We might want to add it to Alleyvate for non-VIP sites, yes, but for our purposes here we're cloning what VIP is providing us with in their skeleton.
Another possibility for how to tackle this would be to actually fetch the latest and greatest from the VIP skeleton repo rather than maintaining a copy here. If installing VIP, then clone skeleton, copy relevant files, etc.
There was a problem hiding this comment.
i think we should make a separate issue for the automating the download of the VIP Config file.
Sorry @jakewrfoster forgot about this, amended now |
vip-config.phpfile