Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PHPStan #193

Merged
merged 13 commits into from
Apr 7, 2023
Merged

Adding PHPStan #193

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f7d404b
Including a base phpstan configuration
srtfisher Apr 7, 2023
43c9eff
Fixing codebase for phpstan
srtfisher Apr 7, 2023
440df28
Add PHPStan to the configuration script
srtfisher Apr 7, 2023
315b05a
Exclude node_modules
srtfisher Apr 7, 2023
1807626
Add support for renaming the plugin.php file
srtfisher Apr 7, 2023
8e6f26b
Getting configure to pass phpstan
srtfisher Apr 7, 2023
e813b7a
Fix regex
srtfisher Apr 7, 2023
ea25fa6
Change order to prompt for plugin name first
srtfisher Apr 7, 2023
30d9630
Restore .github/workflows/merge-develop-to-scaffold.yml
srtfisher Apr 7, 2023
af8e004
Adding a code quality command
srtfisher Apr 7, 2023
10a8f9a
Ensure that a new line is added at the end to appease phpcs
srtfisher Apr 7, 2023
f104f08
code->coding
srtfisher Apr 7, 2023
840e03c
Remove nunomaduro/collision since it is in mantle
srtfisher Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/coding-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Code Quality

on:
push:
branches:
- main
pull_request:
schedule:
- cron: '0 0 * * *'

jobs:
coding-quality:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
coding-quality:
code-quality:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I forgot to update in the original repo.

uses: alleyinteractive/.github/.github/workflows/php-code-quality.yml@main
2 changes: 1 addition & 1 deletion bin/create-block/templates/javascript/index.php.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @see https://developer.wordpress.org/reference/functions/register_block_type/
*/
function {{namespaceSnakeCase}}_{{slugSnakeCase}}_block_init() {
function {{namespaceSnakeCase}}_{{slugSnakeCase}}_block_init(): void {
// Register the block by passing the location of block.json.
register_block_type(
__DIR__
Expand Down
2 changes: 1 addition & 1 deletion bin/create-block/templates/typescript/index.php.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @see https://developer.wordpress.org/reference/functions/register_block_type/
*/
function {{namespaceSnakeCase}}_{{slugSnakeCase}}_block_init() {
function {{namespaceSnakeCase}}_{{slugSnakeCase}}_block_init(): void {
// Register the block by passing the location of block.json.
register_block_type(
__DIR__
Expand Down
5 changes: 4 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"require-dev": {
"alleyinteractive/alley-coding-standards": "^1.0",
"mantle-framework/testkit": "^0.10",
"nunomaduro/collision": "^5.0"
"nunomaduro/collision": "^5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? Since @mantle-framework/testkit already bundles it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mantle-framework/testing/blob/709076ab3e61668da048e343324c027d0737ce66/composer.json#L15

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

"szepeviktor/phpstan-wordpress": "^1.1"
},
"config": {
"allow-plugins": {
Expand All @@ -47,8 +48,10 @@
"phpcbf": "phpcbf .",
"phpcs": "phpcs .",
"phpunit": "phpunit",
"phpstan": "phpstan --memory-limit=512M",
"test": [
"@phpcs",
"@phpstan",
"@phpunit"
]
}
Expand Down
Loading