Fix static/dynamic block variants, add prompt for block templates, HMR support for blocks. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srtfisher
approved these changes
Mar 31, 2023
| @@ -13,8 +13,7 @@ | |||
| ], | |||
| "scripts": { | |||
| "build": "wp-scripts build --webpack-copy-php --webpack-src-dir=blocks", | |||
| "dev": "npm run start", | |||
There was a problem hiding this comment.
Wonder if we should keep dev around so that folks have a consistent experience when starting a project's development environment. npm run dev is what I reach to first when starting up at least
There was a problem hiding this comment.
yeah, good point. I saw it and was just trying to clean up. But that certainly makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses an issue where the
create-blockscript was not generating the static and dynamic variants of blocks. It also adds a prompt for selecting between block templates, and includes both variants within the selection. Additionally, this PR adds HMR (Hot Module Replacement) support for blocks in the editor.Changes Made
staticanddynamicvariants of blocks.mapReason for Changes
The changes were made to improve the functionality and usability of the create-block script by ensuring that it generates all necessary block variants and providing the ability to select between block templates. The addition of HMR support for blocks in the editor is intended to improve the development experience by allowing for faster iteration and feedback during development.
Fixes #163