Fix error when loading all patches with windows that have bands at lower resolution #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wer resolution. In rslearn.train.Dataset, load_all_patches means we load all patches of a fixed size that together cover the window. This means sometimes the patches can be close to the border of the window, e.g. if window bounds is [0, 0, 257, 257] with 256x256 patch size then one patch would be [256, 256, 512, 512]. This is fine but if there's a lower resolution band (negative zoom offset) it could end up being out of bounds. Previously the GeotiffRasterFormat retuned None if it is out of bounds for some reason, so this just fixes it to return a zero-valued array of the appropriate # bands and dtype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rslearn.train.Dataset, load_all_patches means we load all patches of a fixed size that together cover the window. This means sometimes the patches can be close to the border of the window, e.g. if window bounds is [0, 0, 257, 257] with 256x256 patch size then one patch would be [256, 256, 512, 512]. This is fine but if there's a lower resolution band (negative zoom offset) it could end up being out of bounds.
Previously the GeotiffRasterFormat retuned None if it is out of bounds for some reason, so this just fixes it to return a zero-valued array of the appropriate # bands and dtype.