Alias override for wildchat/ultrachat #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # so hash gets added at the end the name. We strip if the hash matches the known one. | ||
| if metric.alias in {'wildchat_masked_ppl-67b0e9', 'ultrachat_masked_ppl-831470'}: | ||
| metric_alias, _ = metric.alias.rsplit('-', 1) | ||
| metric.task_config.setdefault("metadata", {}).setdefault("alias", metric_alias) |
There was a problem hiding this comment.
Bug: Alias Overwrite Fails with setdefault
Using setdefault for the alias key won't override an existing value. If metric.task_config["metadata"]["alias"] already contains one of the hash-suffixed names like wildchat_masked_ppl-67b0e9, the setdefault call won't replace it with the cleaned version, causing the assertion on line 111 to fail. Direct assignment ["alias"] = metric_alias is needed instead of .setdefault("alias", metric_alias) to ensure the cleaned alias always replaces any existing value.
Member
Author
There was a problem hiding this comment.
not an issue. if the task had an alias already, we wouldn't need this trick.
Member
|
Ah 😅 thanks for adding |
davidheineman
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildchat and Utrachat PPL don't have task aliases. This adds a quick hack to get around the issue by dropping hash.
Note
Normalize wildchat/ultrachat masked PPL task aliases by stripping known hash suffixes and setting the base alias in task metadata.
wildchat_masked_ppl-67b0e9andultrachat_masked_ppl-831470by stripping the hash suffix and settingtask_config.metadata.aliasto the base alias (wildchat_masked_ppl,ultrachat_masked_ppl).Written by Cursor Bugbot for commit 4de343e. This will update automatically on new commits. Configure here.