-
Notifications
You must be signed in to change notification settings - Fork 11
[WIP] anneal swarm #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: olmo3-anneals
Are you sure you want to change the base?
[WIP] anneal swarm #138
Conversation
Add torchao installation to conversion
Remove github cli from decon setup
Add `olmo3:dev:7b:main:v1`
This reverts commit a916253.
* remove legacy tasks * `olmo3:dev:midtrain:v2` based on final adapt configs * typo * update olmo3:midtrain_large_scale
* bumping * support zones Signed-off-by: Luca Soldaini <lucas@allenai.org> --------- Signed-off-by: Luca Soldaini <lucas@allenai.org>
| SourceConfig(name=leaf_name, paths=leaf_paths) | ||
| for leaf_name, leaf_paths in get_leaf_configs(sc) | ||
| ) | ||
| source_configs = leaf_configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Cache Key Mismatch After Topic Expansion
Cache key is computed from original source configs (before topic expansion) but cache values are computed from expanded leaf configs (after topic expansion). The cache hash is calculated on line 52-57 using [(sc.name, sc.paths) for sc in source_configs], but then on lines 74-81, the source_configs are transformed to leaf_configs which have different names (e.g., "source:topic" format). This means the cache will be keyed by the unexpanded structure but will contain data using the expanded leaf names, causing cache mismatches where saved cache data cannot be properly retrieved or used. The cache hash should be recalculated after the leaf expansion, or the leaf expansion should happen before the hash calculation.
Done:
To smoke test:
Note
Cursor Bugbot is generating a summary for commit f25a39d. Configure here.