Adds ZST support in Deduper and Mixer #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soldni
requested review from
undfined and
Whattabatt
and removed request for
undfined
Whattabatt
reviewed
Jun 5, 2024
| // the local_input path, because the local_input path could be a temporary with suffix ".tmp" | ||
| let input_compression: String = match compression.input { | ||
| Some(ref input) => input.clone(), | ||
| None => MultiStream::infer_compression_from_temp(local_input.clone()), |
There was a problem hiding this comment.
I think the comment contradicts what you're doing here - you say you'll use docs_location but use local_input
src/shard.rs
Outdated
| ); | ||
| let mut writer = output_stream.writer()?; | ||
| // let output_file = OpenOptions::new() |
src/shard.rs
Outdated
| local_attr_readers.push((local_attr_file, attr_reader.lines())); | ||
| attr_reader_failure_counts.push(0); | ||
|
|
||
| // let f = OpenOptions::new() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.