Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JQ syntax for replacements + added minimum score. #133

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

soldni
Copy link
Member

@soldni soldni commented Mar 6, 2024

No description provided.

@soldni soldni requested a review from rodneykinney March 6, 2024 00:22
@@ -157,7 +398,7 @@ impl DocFilter {
pub fn new(filter_config: Option<&FilterConfig>) -> Result<DocFilter, io::Error> {
match filter_config {
Some(filter_config) => match filter_config.syntax.as_deref() {
Some("jaq") => Ok(DocFilter::JqDocFilter(JqDocFilter::new(filter_config)?)),
Some("jq") => Ok(DocFilter::JqDocFilter(JqDocFilter::new(filter_config)?)),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a mismatch in previous PR: I was using "jq" for syntax in python, but "jaq" here. Opting for "jq" since that's more well known.

@soldni soldni merged commit a75bf09 into main Mar 6, 2024
14 checks passed
@soldni soldni deleted the soldni/rust-sel branch March 6, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants