Open
Conversation
Lucaweihs
reviewed
Oct 16, 2023
Contributor
Lucaweihs
left a comment
There was a problem hiding this comment.
Hi @Richienb, in principle I am happy to make a change like this, though I think we'd need to do something like:
rel_base_dir = posixpath.normpath(os.path.relpath(os.path.abspath(args.experiment_base), os.getcwd()))to retain the same behavior of ensuring the path is relative the current working directory. Before making this change though: this change suggests that you're trying to get allenact working with Windows. Have you successfully done so? This isn't a use case we officially support (as most development is done on Mac/Linux) but I'd be interested in hearing otherwise.
Author
|
I have not yet succeeding in running allenact on Windows, this pr contains a change I made which fixes an error that was thrown, though there are likely more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.path.abspathuses forward slashes on posix and back slashes on Windows.This is a problem because the next line of code splits the string by (only) forward slashes.
Instead, we can use
posixpath.normpathwhich always uses forward slashes.