Skip to content

Distinct operation #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2022
Merged

Distinct operation #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
daeb50f
operation impl
May 27, 2022
5d2a20b
distinct unit tests
May 27, 2022
94262f1
Enriched operation provider
May 27, 2022
5b592fc
Max line length fix
May 30, 2022
e79beab
Merge branch 'main' into distinct-operation
KTGypsy May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions operations-stdlib/src/commonMain/kotlin/OperationsProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import array.Distinct
import array.Find
import array.Size
import operation.FunctionalLogicOperation
Expand All @@ -23,8 +24,10 @@ object OperationsProvider {

// array
"size" to Size,
"reverse" to Reverse,
"toArray" to ToArray
"distinct" to Distinct,
"toArray" to ToArray,

"reverse" to Reverse
)

val functionalOperations: Map<String, FunctionalLogicOperation> = mutableMapOf(
Expand Down
15 changes: 15 additions & 0 deletions operations-stdlib/src/commonMain/kotlin/array/Distinct.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package array

import operation.StandardLogicOperation
import utils.asList
import utils.isSingleNullList

object Distinct : StandardLogicOperation {
override fun evaluateLogic(expression: Any?, data: Any?): Any? {
return when (val firstItem = expression.asList.firstOrNull()) {
is List<*> -> firstItem.distinct()
firstItem.isSingleNullList() -> null
else -> null
}
}
}
182 changes: 182 additions & 0 deletions operations-stdlib/src/commonTest/kotlin/array/DistinctTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,182 @@
package array

import JsonLogicEngine
import JsonLogicResult.Failure
import JsonLogicResult.Success
import TestInput
import io.kotest.core.spec.style.FunSpec
import io.kotest.datatest.withData
import io.kotest.matchers.shouldBe

class DistinctTest : FunSpec({
val logicEngine = JsonLogicEngine.Builder().addStandardOperation("distinct", Distinct).build()

withData(
nameFn = { input -> "Should evaluated ${input.expression} with given ${input.data} result in ${input.result}" },
ts = listOf(
TestInput(
expression = mapOf("distinct" to listOf(listOf(listOf("apple"), listOf("apple"), listOf("pineapple")))),
result = Success(listOf(listOf("apple"), listOf("pineapple")))
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(listOf(null), listOf(null), listOf(null)))),
result = Success(listOf(listOf(null)))
),
TestInput(
expression = mapOf("distinct" to 1.3),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to listOf("true", true, 0, 1)),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to listOf(listOf("true", true, 0, 1))),
result = Success(listOf("true", true, 0, 1))
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(null, null, null, null))),
result = Success(listOf(null))
),
TestInput(
expression = mapOf(
"distinct" to listOf(
listOf(
mapOf("var" to "fruit"),
mapOf("var" to "vegetable"),
mapOf("var" to "mushroom")
)
)
),
data = mapOf("fruit" to null, "vegetable" to null, "mushroom" to true),
result = Success(listOf(null, true))
),
TestInput(
expression = mapOf("distinct" to "banana"),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to emptyList<Any>()),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to null),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to true),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to emptyList<Any>()),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to listOf(null, mapOf("var" to ""))),
result = Failure.NullResult
),
TestInput(
expression = mapOf("distinct" to listOf(emptyList<String>(), mapOf("var" to ""))),
result = Success(emptyList<String>())
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(false, false), mapOf("var" to ""))),
result = Success(listOf(false))
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(true, false), mapOf("var" to ""))),
result = Success(listOf(true, false))
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(true, false))),
result = Success(listOf(true, false))
),
TestInput(
expression = mapOf(
"distinct" to listOf(
mapOf(
"filter" to listOf(
mapOf("var" to "integers"),
mapOf("%" to listOf(mapOf("var" to ""), 2))
)
), mapOf(">" to listOf(mapOf("var" to ""), 1))
)
),
data = mapOf("integers" to listOf(1, 2, 3, 4, 5)),
result = Success(listOf(1, 3, 5))
),
TestInput(
expression = mapOf(
"distinct" to listOf(
listOf(-1, 1, 2, 3),
mapOf(">" to listOf(mapOf("var" to ""), 0))
)
),
result = Success(listOf(-1, 1, 2, 3))
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(7, 7, 7), mapOf("==" to listOf(mapOf("var" to ""), 0)))),
result = Success(listOf(7))
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(3, 3), mapOf("===" to listOf(mapOf("var" to ""), 0)))),
result = Success(listOf(3))
),
TestInput(
expression = mapOf("distinct" to listOf(listOf(0, 1, 0), mapOf("!=" to listOf(mapOf("var" to ""), 0)))),
result = Success(listOf(0, 1))
),
TestInput(
expression = mapOf(
"distinct" to listOf(
listOf(-1, "b", "a", true),
mapOf(">" to listOf(mapOf("var" to ""), 0))
)
),
result = Success(listOf(-1, "b", "a", true))
),
TestInput(
expression = mapOf(
"distinct" to listOf(
listOf("strawberry", true, 2, 3),
mapOf("<" to listOf(mapOf("var" to ""), 0))
)
),
result = Success(listOf("strawberry", true, 2, 3))
),
TestInput(
expression = mapOf(
"distinct" to listOf(
listOf("banana", "apple"),
mapOf("==" to listOf(mapOf("var" to ""), "apple"))
)
),
result = Success(listOf("banana", "apple"))
),
TestInput(
expression = mapOf(
"distinct" to listOf(
mapOf("var" to "fruits"),
mapOf("==" to listOf(mapOf("var" to ""), "pineapple"))
)
),
data = mapOf("fruits" to listOf("apple", "banana", "pineapple")),
result = Success(listOf("apple", "banana", "pineapple"))
),
TestInput(
expression = mapOf(
"distinct" to listOf(listOf("a", 3, "c"))
),
result = Success(listOf("a", 3, "c"))
),
)
// given
) { testInput: TestInput ->
// when
val evaluationResult = logicEngine.evaluate(testInput.expression, testInput.data)

// then
evaluationResult shouldBe testInput.result
}
})