Sligtly improve failure API

core/src/commonMain/kotlin/CommonJsonLogicEngine.kt

@@ -4,16 +4,16 @@ internal class CommonJsonLogicEngine(private val evaluator: LogicEvaluator) : Js
             it.isNotEmpty()
         }?.let {
             safeEvaluate(expression, data)
-        } ?: JsonLogicResult.EmptyExpressionFailure
+        } ?: JsonLogicResult.Failure.EmptyExpression
 
     private fun safeEvaluate(expression: Map<String, Any?>, data: Any?) = runCatching {
         evaluator.evaluateLogic(expression, data)
     }.fold(
         onSuccess = ::toJsonLogicResult,
-        onFailure = { JsonLogicResult.MissingOperationFailure }
+        onFailure = { JsonLogicResult.Failure.MissingOperation }
     )
 
     private fun toJsonLogicResult(evaluatedValue: Any?) = evaluatedValue?.let { notNullResult ->
         JsonLogicResult.Success(notNullResult)
-    } ?: JsonLogicResult.NullResultFailure
+    } ?: JsonLogicResult.Failure.NullResult
 }

core/src/commonMain/kotlin/JsonLogicResult.kt

@@ -1,6 +1,10 @@
 sealed class JsonLogicResult {
     data class Success(val value: Any) : JsonLogicResult()
-    object NullResultFailure : JsonLogicResult()
-    object EmptyExpressionFailure : JsonLogicResult()
-    object MissingOperationFailure : JsonLogicResult()
+
+    sealed class Failure : JsonLogicResult() {
+        object NullResult : Failure()
+        object EmptyExpression : Failure()
+        object MissingOperation : Failure()
+    }
+
 }

core/src/commonTest/kotlin/CommonJsonLogicEngineTest.kt

@@ -12,7 +12,7 @@ class CommonJsonLogicEngineTest : BehaviorSpec({
             val result = logicEngine.evaluate(logicExpression, null)
 
             then("returns missing operation failure result") {
-                result shouldBe JsonLogicResult.MissingOperationFailure
+                result shouldBe JsonLogicResult.Failure.MissingOperation
             }
         }
     }
@@ -24,7 +24,7 @@ class CommonJsonLogicEngineTest : BehaviorSpec({
             val result = logicEngine.evaluate(logicExpression, null)
 
             then("returns empty expression failure result") {
-                result shouldBe JsonLogicResult.EmptyExpressionFailure
+                result shouldBe JsonLogicResult.Failure.EmptyExpression
             }
         }
     }
@@ -36,7 +36,7 @@ class CommonJsonLogicEngineTest : BehaviorSpec({
             val result = logicEngine.evaluate(logicExpression, null)
 
             then("returns null failure result") {
-                result shouldBe JsonLogicResult.NullResultFailure
+                result shouldBe JsonLogicResult.Failure.NullResult
             }
         }
     }

core/src/commonTest/kotlin/operations/array/ReduceTest.kt

@@ -21,7 +21,7 @@ class ReduceTest : FunSpec({
                         9
                     )
                 ),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf(
@@ -32,14 +32,14 @@ class ReduceTest : FunSpec({
                     )
                 ),
                 data = mapOf("b" to "banana"),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf(
                     "reduce" to listOf(mapOf("var" to "integers"))
                 ),
                 data = mapOf("integers" to listOf(1, 2, 3, 4)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf(
@@ -48,25 +48,25 @@ class ReduceTest : FunSpec({
                         0
                     )
                 ),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("reduce" to listOf(0)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("reduce" to emptyList<Any>()),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("reduce" to null),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf(
                     "reduce" to listOf(listOf(1, 2), null, 4)
                 ),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("reduce" to listOf(mapOf("var" to "integers"), 0)),

core/src/commonTest/kotlin/operations/data/VarTest.kt

@@ -16,45 +16,45 @@ class VarTest : FunSpec({
             TestInput(
                 expression = mapOf("var" to "b"),
                 data = mapOf("a" to 1),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("var" to "a"), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("var" to "a"), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("var" to listOf(listOf(""))),
                 data = listOf(1, 2, 3, 4),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("var" to listOf(listOf(null))),
                 data = listOf(1, 2, 3, 4),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("var" to listOf("b")),
                 data = mapOf("a" to 1),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("var" to listOf("b")), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("var" to listOf("b")), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("var" to listOf(emptyList<Any>())),
                 data = listOf(1, 2, 3, 4),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("var" to "a.b.c"), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("var" to "a.b.c"), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("var" to "a.b.c"),
                 data = mapOf("a" to null),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("var" to "a.q"),
                 data = mapOf("a" to mapOf("b" to "c")),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("var" to "a.b.c"),
                 data = mapOf("a" to mapOf("b" to null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf(

core/src/commonTest/kotlin/operations/logic/IfTest.kt

@@ -210,16 +210,16 @@ class IfTest : FunSpec({
             ),
             TestInput(
                 expression = mapOf("if" to listOf(false, "apple")),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("if" to listOf<Any>()), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("if" to listOf<Any>()), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("if" to listOf(false, "apple", false, "banana")),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("if" to listOf(false, "apple", false, "banana", false, "carrot")),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             )
         )
         // given

core/src/commonTest/kotlin/operations/numeric/AdditionTest.kt

@@ -83,55 +83,55 @@ class AdditionTest : FunSpec({
             ),
             TestInput(
                 expression = mapOf("+" to listOf(2, 2, null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("+" to listOf("1", 1.5, "banana")),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("+" to listOf("1", 1, listOf("banana"))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("+" to listOf("a", 2)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("+" to listOf("a", 2)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("+" to listOf(listOf("a", 2), 2)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("+" to listOf(listOf(2, "a"), listOf("a", 2))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("+" to listOf(null, 5)), result = JsonLogicResult.NullResultFailure),
-            TestInput(expression = mapOf("+" to listOf(5, null)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("+" to listOf(null, 5)), result = JsonLogicResult.Failure.NullResult),
+            TestInput(expression = mapOf("+" to listOf(5, null)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("+" to listOf(null, null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("+" to listOf(null)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("+" to listOf(null)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("+" to listOf(true, false)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("+" to listOf(true)), result = JsonLogicResult.NullResultFailure),
-            TestInput(expression = mapOf("+" to listOf(false)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("+" to listOf(true)), result = JsonLogicResult.Failure.NullResult),
+            TestInput(expression = mapOf("+" to listOf(false)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("+" to listOf(true, null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("+" to listOf(false, null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("+" to listOf(false, true)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("+" to listOf(0, true)), result = JsonLogicResult.NullResultFailure),
-            TestInput(expression = mapOf("+" to listOf(1, true)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("+" to listOf(0, true)), result = JsonLogicResult.Failure.NullResult),
+            TestInput(expression = mapOf("+" to listOf(1, true)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("+" to listOf(emptyList<String>(), 2)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
         )
         // given

core/src/commonTest/kotlin/operations/numeric/DivisionTest.kt

@@ -77,57 +77,57 @@ class DivisionTest : FunSpec({
                 expression = mapOf("/" to listOf(emptyList<String>(), 2)),
                 result = JsonLogicResult.Success(0)
             ),
-            TestInput(expression = mapOf("/" to listOf("1", "0")), result = JsonLogicResult.NullResultFailure),
-            TestInput(expression = mapOf("/" to listOf("1", 0)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("/" to listOf("1", "0")), result = JsonLogicResult.Failure.NullResult),
+            TestInput(expression = mapOf("/" to listOf("1", 0)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("/" to listOf("2.5", listOf("2", "3", 5))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("/" to listOf(2, null)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("/" to listOf(2, null)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("/" to listOf(null, null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("/" to listOf(null)), result = JsonLogicResult.NullResultFailure),
-            TestInput(expression = mapOf("/" to listOf("banana")), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("/" to listOf(null)), result = JsonLogicResult.Failure.NullResult),
+            TestInput(expression = mapOf("/" to listOf("banana")), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("/" to listOf(true, false)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("/" to listOf(true)), result = JsonLogicResult.NullResultFailure),
-            TestInput(expression = mapOf("/" to listOf(false)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("/" to listOf(true)), result = JsonLogicResult.Failure.NullResult),
+            TestInput(expression = mapOf("/" to listOf(false)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("/" to listOf(true, null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("/" to listOf(false, null)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
-            TestInput(expression = mapOf("/" to listOf("a", 2)), result = JsonLogicResult.NullResultFailure),
+            TestInput(expression = mapOf("/" to listOf("a", 2)), result = JsonLogicResult.Failure.NullResult),
             TestInput(
                 expression = mapOf("/" to listOf(listOf(2, "a"), 2)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("/" to listOf(listOf("a", 2), 2)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("/" to listOf(listOf(2, 2), 2)),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("/" to listOf(listOf(2, "a"), listOf("a", 2))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("/" to listOf(listOf("5", listOf("5")), listOf("5"), listOf("5"))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("/" to listOf(listOf(listOf("5"), listOf(6)))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
         )
         // given

core/src/commonTest/kotlin/operations/numeric/MaxTest.kt

@@ -35,11 +35,11 @@ class MaxTest : FunSpec({
             ),
             TestInput(
                 expression = mapOf("max" to listOf(1, "banana")),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("max" to listOf(1, "banana", listOf(1, 2))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("max" to listOf(1, "2")),

core/src/commonTest/kotlin/operations/numeric/MinTest.kt

@@ -43,11 +43,11 @@ class MinTest : FunSpec({
             ),
             TestInput(
                 expression = mapOf("min" to listOf(1, "banana")),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
             TestInput(
                 expression = mapOf("min" to listOf(1, "banana", listOf(1, 2))),
-                result = JsonLogicResult.NullResultFailure
+                result = JsonLogicResult.Failure.NullResult
             ),
         )
         // given