Skip to content

Failure result subtypes #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 4, 2022
Merged

Failure result subtypes #57

merged 16 commits into from
May 4, 2022

Conversation

KTGypsy
Copy link
Contributor

@KTGypsy KTGypsy commented Apr 28, 2022 •
edited
Loading

What:

  • Single failure result class split into: Null, MissingOperation, EmptyExpression failure results

Why:

  • To better indicate whats going on in the library when collecting evaluated results
  • To improve readability in unit tests.

Example:

  • All of the unit tests use it

@KTGypsy KTGypsy marked this pull request as ready for review April 28, 2022 11:41
@KTGypsy KTGypsy merged commit 456c2ff into main May 4, 2022
@KTGypsy KTGypsy deleted the failure-result-subtypes branch May 4, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulinaSadowskaAllegro PaulinaSadowskaAllegro PaulinaSadowskaAllegro approved these changes

@mkrogulskiallegro2 mkrogulskiallegro2 mkrogulskiallegro2 approved these changes

@pavlo-davydiuk pavlo-davydiuk Awaiting requested review from pavlo-davydiuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KTGypsy @PaulinaSadowskaAllegro @mkrogulskiallegro2